Fix The DEFAULT_FILE_STORAGE setting is deprecated warning
#408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
50-Course
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Hello @KOliver94,
Foremost, thank you for your MR. I so happen to run into this same issue while maintaining django-silk earlier this year, making a pass at this. I have gone through the mentioned tickets (#359 & #383), as well as cross-referencing this and the blocking MRs.
That said, this is good to go 🚀
| storage = settings.DEFAULT_FILE_STORAGE | ||
| storage = default_storage |
|
Hey @frankwiles, Is there a chance to check my PR and get rid of the warning? Thanks! |
|
Hey @frankwiles, Django 5.1 is expected to be released in 3 months. The issue has been open for more than a year. There are 3 available PRs with fixes. Can you check #359, #383 or mine here please? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from: #397
There are already two PRs for this (#359, #383) but as they are conflicting with master right now I included it here to avoid the anoying warnings.
Closes #359, closes #383, fixes #366