Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get release by api id #563

Merged
merged 5 commits into from Dec 3, 2022
Merged

feat: get release by api id #563

merged 5 commits into from Dec 3, 2022

Conversation

kevcube
Copy link
Contributor

@kevcube kevcube commented Dec 3, 2022

No description provided.

@kevcube
Copy link
Contributor Author

kevcube commented Dec 3, 2022

@robinraju I think my fork won't have access to run that action to test download from private repo

Copy link
Owner

@robinraju robinraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevcube Thanks for submitting this PR. The build fails because GitHub doesn't share tokens configured on action to forked repos. It looks good to me apart from a minor comment

src/release-downloader.ts Show resolved Hide resolved
@kevcube
Copy link
Contributor Author

kevcube commented Dec 3, 2022

done

@kevcube
Copy link
Contributor Author

kevcube commented Dec 3, 2022

whoops, NOW done

@robinraju
Copy link
Owner

whoops, NOW done

Just added one more commit where I added the missing field to settings.

@robinraju robinraju merged commit d64632d into robinraju:main Dec 3, 2022
mudler pushed a commit to kairos-io/provider-kairos that referenced this pull request Dec 28, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[robinraju/release-downloader](https://togithub.com/robinraju/release-downloader)
| action | minor | `v1.6` -> `v1.7` |

---

### Release Notes

<details>
<summary>robinraju/release-downloader</summary>

###
[`v1.7`](https://togithub.com/robinraju/release-downloader/releases/tag/v1.7):
Release Downloader v1.7

[Compare
Source](https://togithub.com/robinraju/release-downloader/compare/v1.6...v1.7)

#### What's Changed

- feat: get release by api id by
[@&#8203;kevcube](https://togithub.com/kevcube) in
[robinraju/release-downloader#563
- fix reading releaseId from inputs by
[@&#8203;robinraju](https://togithub.com/robinraju) in
[robinraju/release-downloader#564

##### Dependency Updates

- Bump qs from 6.10.2 to 6.11.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[robinraju/release-downloader#568
- Dependabot updates by
[@&#8203;robinraju](https://togithub.com/robinraju) in
[robinraju/release-downloader#569
- Dependency updates by
[@&#8203;robinraju](https://togithub.com/robinraju) in
[robinraju/release-downloader#578

#### New Contributors

- [@&#8203;kevcube](https://togithub.com/kevcube) made their first
contribution in
[robinraju/release-downloader#563

**Full Changelog**:
robinraju/release-downloader@v1.6...v1.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4wIiwidXBkYXRlZEluVmVyIjoiMzQuNzMuMyJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants