Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript migration #98

Merged
merged 5 commits into from Mar 3, 2020
Merged

Typescript migration #98

merged 5 commits into from Mar 3, 2020

Conversation

rodlukas
Copy link
Owner

@rodlukas rodlukas commented Mar 3, 2020

#74

- odstraneni explicitnich <Fragment> -> <>
- camelcase napric aplikaci krom prace s API
- pouzivani event.currentTarget napric aplikaci misto event.target
- refaktoring nazvu css trid u komponent
- setInterval a setTimeout explicitne vazany k window
- smazani vsech pozustatku po Flow (flow typy, zmeny v souborech)
- prepsani Bank.js, nadefinovani presne podoby API pro banku
- zjednoduseni GoogleAnalytics.js
- upravy a refaktoring komponent tak, aby bylo jejich pouziti jednoznacne a v souladu s typy
- u FontAwesome ikon bylo potreba obalit je span s ID, protoze ID nemaji povoleno
- osetreni mnoha hranicnich pripadu navic
- odstraneni zbytecneho ID ve stavech formularu
- odstraneni zbytecnych props, ktere se vyuzivaly, ale diky zjednoduseni uz nebyly potreba
- zavedeni dummy objektu s vychozimi hodnotami pro formulare pri pridavani
- osetreni prace s tokenem v ErrorBoundary.js
- pridani dalsich pravidel ESlint
- uprava README.md: zmena a doplneni technologii
…disable

pri chybe se nezobrazil duvod chyby, zpusobeno spatnou migraci na TS
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files           9        9           
  Lines         577      577           
=======================================
  Hits          494      494           
  Misses         83       83
Impacted Files Coverage Δ
api/services.py 45.83% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c111b...5a6f488. Read the comment docs.

@rodlukas rodlukas merged commit 05585b3 into master Mar 3, 2020
@rodlukas rodlukas deleted the typescript_migration branch March 3, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant