fix(node-resolve): handle "package.json" being in path #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
requested review from
shellscape,
guybedford,
LarsDenBakker and
lukastaegert
This was referenced Jul 3, 2021
guybedford
approved these changes
Jul 3, 2021
shellscape
force-pushed
the
master
branch
9 times, most recently
from
cc53f0f
to
9c6e762
Compare
shellscape
force-pushed
the
master
branch
2 times, most recently
from
c33e948
to
1ae22f4
Compare
shellscape
force-pushed
the
node-resolve-refactor
branch
from
12c46e3
to
43c20cc
Compare
shellscape
force-pushed
the
node-resolve-refactor
branch
from
43c20cc
to
f493831
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
Description
I spotted we were doing a
const pkgDr = pkgJsonPath.replace('package.json', '');, which would fail if "package.json" was anywhere else in the path (which admittedly is probably an edge case), so decided to fix that.In the process I found a similar bug with eslint 馃槄 so will be opening a PR there too, but for now have disabled the folder that triggers that bug in the config file.