Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terser): emit source map #1383

Merged
merged 3 commits into from Jan 6, 2023
Merged

feat(terser): emit source map #1383

merged 3 commits into from Jan 6, 2023

Conversation

tada5hi
Copy link
Member

@tada5hi tada5hi commented Dec 21, 2022 •
edited

Rollup Plugin Name: terser

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

feat #1371

@tada5hi tada5hi marked this pull request as draft December 21, 2022 20:04
@tada5hi
Copy link
Member Author

tada5hi commented Dec 22, 2022 •
edited

@shellscape this is a bit non related here.
But can you take a look at the codeowner (here) file in the root directory.
It still complains about missing permissions.

@shellscape
Copy link
Collaborator

what complains about what?

@tada5hi
Copy link
Member Author

tada5hi commented Dec 22, 2022 •
edited

@shellscape I'm not quite sure. If you open the file in GitHub, it displays: "This CODEOWNERS file contains errors"
When you hover over the marked line it shows the following dialogue:
Unknown owner: make sure @tada5hi exists and has write access to the repository

@shellscape
Copy link
Collaborator

wouldn't worry about it right now. you should get notified of PRs against the plugin.

@tada5hi tada5hi marked this pull request as ready for review December 23, 2022 09:59
@tada5hi
Copy link
Member Author

tada5hi commented Dec 23, 2022

@shellscape would be great if you could have a look. I think the pr can be merged ✌️

@tada5hi
Copy link
Member Author

tada5hi commented Dec 24, 2022

@shellscape let me know if something is missing ✌️.

@rotu rotu mentioned this pull request Dec 25, 2022
Merged
@Greenheart Greenheart mentioned this pull request Dec 28, 2022
Closed
@dnalborczyk dnalborczyk mentioned this pull request Dec 30, 2022
Merged
9 tasks
shellscape
shellscape requested changes Jan 2, 2023
View reviewed changes
packages/terser/test/test.js Outdated Show resolved Hide resolved
@tada5hi tada5hi removed the request for review from lukastaegert January 2, 2023 21:39
@tada5hi
Copy link
Member Author

tada5hi commented Jan 3, 2023

@shellscape can you have a look again ?

@shellscape shellscape merged commit 9779aa3 into rollup:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellscape shellscape shellscape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tada5hi @shellscape