Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Treat sideEffects array as inclusion list #227

Merged
merged 4 commits into from
Jun 22, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export default function nodeResolve ( options = {} ) {
packageInfo.hasModuleSideEffects = () => packageSideEffects;
} else if (Array.isArray(packageSideEffects)) {
const filter = createFilter(packageSideEffects, null, {resolve: pkgRoot});
packageInfo.hasModuleSideEffects = id => !filter(id);
packageInfo.hasModuleSideEffects = id => filter(id);
mikeharder marked this conversation as resolved.
Show resolved Hide resolved
}

packageInfoCache.set(pkgPath, packageInfo);
Expand Down
2 changes: 1 addition & 1 deletion test/node_modules/side-effects-array/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/node_modules/side-effects-array/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -890,9 +890,10 @@ describe( 'rollup-plugin-node-resolve', function () {
'true-dep1',
'true-dep2',
'true-index',
'array-dep2',
'array-dep4',
'true-index'
'array-dep1',
'array-dep3',
'array-dep5',
'array-index'
]);
delete global.sideEffects;
}));
Expand Down