Handle loading symlinked config files #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3783 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 185 185
Lines 6466 6467 +1
Branches 1875 1875
=======================================
+ Hits 6274 6275 +1
Misses 101 101
Partials 91 91
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
gh-3781-symlinked-config
branch
from
1116234
to
eda8db8
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3781
Description
The reason at its core here is that when using
require.cacheto intercept module loading and requiring a symlink, the filename in the cache will always be the symlink target (i.e. a symlink is treated as the symlinked file by Node). This was already handled when specifying an explicit file name but the logic was missing for the default file names. This is fixed now.