New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent exit before stdout is drained #4983
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix-process-exit or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4983 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 222 222
Lines 8131 8133 +2
Branches 2239 2239
=======================================
+ Hits 8049 8051 +2
Misses 28 28
Partials 54 54
|
This PR has been released as part of rollup@3.21.6. You can test it via |
I will revert this change as it caused too many issues elsewhere, see #5004. |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This will ensure that stdout is closed and drained before manually exiting Rollup. Unfortunately, I am not sure if it is possible to test this properly.