build(deps): bump k8s.io/client-go from 0.25.4 to 0.26.0 #11421

dependabot · 2022-12-12T12:04:12Z

Bumps k8s.io/client-go from 0.25.4 to 0.26.0.

Commits

e7cd4ba Update dependencies to v0.26.0 tag
95a14c3 Merge remote-tracking branch 'origin/master' into release-1.26
1a7cd1d Update golang.org/x/net 1e63c2f
53f2fea sync: update go.mod
968ba8d Merge pull request #113797 from seans3/force-no-aggregated
c8ffed3 Merge pull request #111023 from pohly/dynamic-resource-allocation
61cd728 Merge pull request #113826 from jsafrane/add-openstack
cfd682c Merge pull request #113375 from atiratree/PodHealthyPolicy-api
522eaa1 api: generated files
f1c80d7 generated
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

travisn · 2022-12-12T22:07:22Z

When I try to update the go modules locally, I also get the same build error being seen in the bot PR. It's not clear what the solution is yet.

CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go vet  -tags '' github.com/rook/rook/cmd/... github.com/rook/rook/pkg/... github.com/rook/rook/tests/integration
# sigs.k8s.io/controller-runtime/pkg/cache
../../../../pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/cache/informer_cache.go:144:9: cannot use i.Informer (variable of type "k8s.io/client-go/tools/cache".SharedIndexInformer) as type Informer in return statement:
	"k8s.io/client-go/tools/cache".SharedIndexInformer does not implement Informer (wrong type for AddEventHandler method)
		have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
		want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
../../../../pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/cache/informer_cache.go:158:9: cannot use i.Informer (variable of type "k8s.io/client-go/tools/cache".SharedIndexInformer) as type Informer in return statement:
	"k8s.io/client-go/tools/cache".SharedIndexInformer does not implement Informer (wrong type for AddEventHandler method)
		have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
		want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
# github.com/openshift/cluster-api/pkg/apis/machine/v1beta1
../../../../pkg/mod/github.com/openshift/cluster-api@v0.0.0-20191129101638-b09907ac6668/pkg/apis/machine/v1beta1/machineset_types.go:179:83: not enough arguments in call to metav1validation.ValidateLabelSelector
	have (*"k8s.io/apimachinery/pkg/apis/meta/v1".LabelSelector, *field.Path)
	want (*"k8s.io/apimachinery/pkg/apis/meta/v1".LabelSelector, validation.LabelSelectorValidationOptions, *field.Path)
make[1]: *** [go.vet] Error 2
make: *** [build.common] Error 2

subhamkrai · 2022-12-13T08:10:34Z

When I try to update the go modules locally, I also get the same build error being seen in the bot PR. It's not clear what the solution is yet.

CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go vet  -tags '' github.com/rook/rook/cmd/... github.com/rook/rook/pkg/... github.com/rook/rook/tests/integration
# sigs.k8s.io/controller-runtime/pkg/cache
../../../../pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/cache/informer_cache.go:144:9: cannot use i.Informer (variable of type "k8s.io/client-go/tools/cache".SharedIndexInformer) as type Informer in return statement:
	"k8s.io/client-go/tools/cache".SharedIndexInformer does not implement Informer (wrong type for AddEventHandler method)
		have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
		want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
../../../../pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/cache/informer_cache.go:158:9: cannot use i.Informer (variable of type "k8s.io/client-go/tools/cache".SharedIndexInformer) as type Informer in return statement:
	"k8s.io/client-go/tools/cache".SharedIndexInformer does not implement Informer (wrong type for AddEventHandler method)
		have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
		want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
# github.com/openshift/cluster-api/pkg/apis/machine/v1beta1
../../../../pkg/mod/github.com/openshift/cluster-api@v0.0.0-20191129101638-b09907ac6668/pkg/apis/machine/v1beta1/machineset_types.go:179:83: not enough arguments in call to metav1validation.ValidateLabelSelector
	have (*"k8s.io/apimachinery/pkg/apis/meta/v1".LabelSelector, *field.Path)
	want (*"k8s.io/apimachinery/pkg/apis/meta/v1".LabelSelector, validation.LabelSelectorValidationOptions, *field.Path)
make[1]: *** [go.vet] Error 2
make: *** [build.common] Error 2

I tried to look into this and seems like an error is coming from controller-runtime pg

subhamkrai · 2022-12-13T08:11:12Z

we can wait for few days or I'll create an issue in controller runtime, if we all agree it controller-runtime issue

Madhu-1 · 2022-12-13T08:14:29Z

we can wait for few days or I'll create an issue in controller runtime, if we all agree it controller-runtime issue

Looks like controller-runtime just got updated kubernetes 0.26.0 kubernetes-sigs/controller-runtime#2087, need to wait for new controller-runtime release

subhamkrai · 2022-12-13T08:21:02Z

we can wait for few days or I'll create an issue in controller runtime, if we all agree it controller-runtime issue

Looks like controller-runtime just got updated kubernetes 0.26.0 kubernetes-sigs/controller-runtime#2087, need to wait for new controller-runtime release

right, then let's wait for the new release than

Madhu-1 · 2022-12-16T06:01:37Z

New controller-runtime release https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.0 which supports v1.26

travisn · 2022-12-16T17:06:29Z

Now there is just one remaining controller. I'm thinking this stale/unused code and will look at removing it.

CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go vet  -tags '' github.com/rook/rook/cmd/... github.com/rook/rook/pkg/... github.com/rook/rook/tests/integration
# github.com/openshift/cluster-api/pkg/apis/machine/v1beta1
../../../../pkg/mod/github.com/openshift/cluster-api@v0.0.0-20191129101638-b09907ac6668/pkg/apis/machine/v1beta1/machineset_types.go:179:83: not enough arguments in call to metav1validation.ValidateLabelSelector
	have (*"k8s.io/apimachinery/pkg/apis/meta/v1".LabelSelector, *field.Path)
	want (*"k8s.io/apimachinery/pkg/apis/meta/v1".LabelSelector, validation.LabelSelectorValidationOptions, *field.Path)
make[1]: *** [go.vet] Error 2
make: *** [build.common] Error 2

mergify · 2022-12-16T21:59:03Z

This pull request has merge conflicts that must be resolved before it can be merged. @dependabot[bot] please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.25.4 to 0.26.0. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.25.4...v0.26.0) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

github-actions · 2023-01-16T20:01:59Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

mergify · 2023-01-19T18:22:36Z

This pull request has merge conflicts that must be resolved before it can be merged. @dependabot[bot] please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

dependabot · 2023-01-19T18:24:00Z

Superseded by #11569.

dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 12, 2022

travisn mentioned this pull request Dec 16, 2022

core: Remove support for machine disruption budgets #11450

Merged

7 tasks

dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.26.0 branch from 6a7651b to 43b523b Compare December 16, 2022 21:59

github-actions bot added the stale Labeled by the stale bot label Jan 16, 2023

dependabot bot closed this Jan 19, 2023

dependabot bot deleted the dependabot/go_modules/k8s.io/client-go-0.26.0 branch January 19, 2023 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(deps): bump k8s.io/client-go from 0.25.4 to 0.26.0 #11421

build(deps): bump k8s.io/client-go from 0.25.4 to 0.26.0 #11421

dependabot bot commented on behalf of github Dec 12, 2022 •

edited

travisn commented Dec 12, 2022

subhamkrai commented Dec 13, 2022

subhamkrai commented Dec 13, 2022

Madhu-1 commented Dec 13, 2022

subhamkrai commented Dec 13, 2022

Madhu-1 commented Dec 16, 2022

travisn commented Dec 16, 2022

mergify bot commented Dec 16, 2022

github-actions bot commented Jan 16, 2023

mergify bot commented Jan 19, 2023

dependabot bot commented on behalf of github Jan 19, 2023

build(deps): bump k8s.io/client-go from 0.25.4 to 0.26.0 #11421

build(deps): bump k8s.io/client-go from 0.25.4 to 0.26.0 #11421

Conversation

dependabot bot commented on behalf of github Dec 12, 2022 • edited

travisn commented Dec 12, 2022

subhamkrai commented Dec 13, 2022

subhamkrai commented Dec 13, 2022

Madhu-1 commented Dec 13, 2022

subhamkrai commented Dec 13, 2022

Madhu-1 commented Dec 16, 2022

travisn commented Dec 16, 2022

mergify bot commented Dec 16, 2022

github-actions bot commented Jan 16, 2023

mergify bot commented Jan 19, 2023

dependabot bot commented on behalf of github Jan 19, 2023

dependabot bot commented on behalf of github Dec 12, 2022 •

edited