Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update go version in govulncheck ci #14174

Closed

Conversation

subhamkrai
Copy link
Contributor

updating to go version in govulncheck ci as
1.22.3 has some latest govulncheck fixes.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

updating to go version in govulncheck ci as
1.22.3 has some latest govulncheck fixes.

Signed-off-by: subhamkrai <srai@redhat.com>
go-version: "1.22.2"
go-version: "1.22.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize Subham had already opened a PR for this. I found here #14175 that we could revert back to using 1.22 and still get the CVE fix, instead of continuing to manage the .z version. Which do we think would be preferable moving forward?

@BlaineEXE
Copy link
Member

Closing in slight favor of #14175 , since we want to merge this asap to fix CI.

@BlaineEXE BlaineEXE closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants