Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update go version for govulncheck #14175

Merged
merged 1 commit into from
May 8, 2024

Conversation

BlaineEXE
Copy link
Member

@BlaineEXE BlaineEXE commented May 8, 2024

Update the version of Go used for govulncheck to get the latest CVE fix present in Go v1.22.3.

Related: #14027

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Update the version of Go used for govulncheck to get the latest CVE fix
present in Go v1.22.3.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
@BlaineEXE BlaineEXE requested a review from subhamkrai May 8, 2024 14:04
@BlaineEXE BlaineEXE marked this pull request as ready for review May 8, 2024 14:07
@BlaineEXE BlaineEXE requested a review from travisn May 8, 2024 14:07
@@ -54,7 +54,7 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: "1.22.2"
go-version: "1.22"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really strange, I did try this on my patch but it didn't worked

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw @BlaineEXE I had this fix already #14174, but I fine with your patch too

@BlaineEXE BlaineEXE marked this pull request as draft May 8, 2024 16:18
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that we don't need the patch version anymore

@BlaineEXE BlaineEXE marked this pull request as ready for review May 8, 2024 16:23
@BlaineEXE BlaineEXE merged commit 0a08a73 into rook:master May 8, 2024
53 checks passed
@BlaineEXE BlaineEXE deleted the update-govulncheck-version branch May 8, 2024 16:51
BlaineEXE added a commit that referenced this pull request May 8, 2024
ci: update go version for govulncheck (backport #14175)
BlaineEXE added a commit that referenced this pull request May 8, 2024
ci: update go version for govulncheck (backport #14175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants