Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arity #2091

Merged
merged 1 commit into from Feb 27, 2019
Merged

fix arity #2091

merged 1 commit into from Feb 27, 2019

Conversation

ahorek
Copy link

@ahorek ahorek commented Feb 27, 2019

similar to #2089

fixes 2 failures

 template rendering with render_views enabled with a custom renderer prepended to the view path renders the contents of the template
     Failure/Error: lambda { |_template| %("Dynamic template with path '#{_template.virtual_path}'") },
     
     ActionView::Template::Error:
       wrong number of arguments (given 2, expected 1)
     # ./spec/verify_custom_renderers_spec.rb:153:in `block in find_template'
     # ./spec/verify_custom_renderers_spec.rb:120:in `index'
     # /home/travis/build/rspec/bundle/ruby/2.6.0/bundler/gems/rails-controller-testing-21014e48be12/lib/rails/controller/testing/template_assertions.rb:61:in `process'
     # /home/travis/build/rspec/bundle/ruby/2.6.0/bundler/gems/rails-controller-testing-21014e48be12/lib/rails/controller/testing/integration.rb:13:in `block (2 levels) in <module:Integration>'
     # ./spec/verify_custom_renderers_spec.rb:131:in `block (4 levels) in <main>'
     # ------------------
     # --- Caused by: ---
     # ArgumentError:
     #   wrong number of arguments (given 2, expected 1)
     #   ./spec/verify_custom_renderers_spec.rb:153:in `block in find_template'
 template rendering with render_views enabled with a custom renderer prepended to the view path renders the 'baz' template
     Failure/Error: lambda { |_template| %("Dynamic template with path '#{_template.virtual_path}'") },
     
     ActionView::Template::Error:
       wrong number of arguments (given 2, expected 1)
     # ./spec/verify_custom_renderers_spec.rb:153:in `block in find_template'
     # ./spec/verify_custom_renderers_spec.rb:120:in `index'
     # /home/travis/build/rspec/bundle/ruby/2.6.0/bundler/gems/rails-controller-testing-21014e48be12/lib/rails/controller/testing/template_assertions.rb:61:in `process'
     # /home/travis/build/rspec/bundle/ruby/2.6.0/bundler/gems/rails-controller-testing-21014e48be12/lib/rails/controller/testing/integration.rb:13:in `block (2 levels) in <module:Integration>'
     # ./spec/verify_custom_renderers_spec.rb:125:in `block (4 levels) in <main>'
     # ------------------
     # --- Caused by: ---
     # ArgumentError:
     #   wrong number of arguments (given 2, expected 1)
     #   ./spec/verify_custom_renderers_spec.rb:153:in `block in find_template'

@ahorek ahorek changed the base branch from master to 4-0-dev February 27, 2019 21:16
Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. LGTM. Thanks @ahorek

@benoittgt benoittgt merged commit 71d01b3 into rspec:4-0-dev Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants