Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rspec-rails 4.0 release blog post #143

Merged
merged 20 commits into from May 27, 2020
Merged

rspec-rails 4.0 release blog post #143

merged 20 commits into from May 27, 2020

Conversation

benoittgt
Copy link
Member

@benoittgt benoittgt commented May 11, 2020 •
edited

Following: rspec/rspec-rails#2265 (comment)

  • Write feature tests for ActionMailbox
  • Push to relish last rspec-rails doc, that include ActionMailbox specs

@pirj
Copy link
Member

pirj commented May 15, 2020

Sorry, life intervened, it takes me long to review this. Not making any promises on when, but this is on the top of my list.

@benoittgt
Copy link
Member Author

No problem @pirj :)

@benoittgt benoittgt mentioned this pull request May 20, 2020
Closed
pirj
pirj approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Added some really minor notes.

Can you pass the text through some prose linter to make sure proper English is used?

source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
JonRowe
JonRowe requested changes May 21, 2020
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good start, I've tried to edit this a few times but have settled for adding changes as suggestions so I don't keep loosing them! Let me know what you think

source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
@benoittgt
Copy link
Member Author

Thanks for all your feedbacks. I will handle this tomorrow :)

pirj
pirj approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
Thank you, Benoit.

  • Yours "Looks good" guy :D

@benoittgt
Copy link
Member Author

Ahah, thanks. I will ping you again when #143 (comment) will be done :)

JonRowe
JonRowe requested changes May 22, 2020
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more feedback after the changes were merged, reviewing blog posts is hard 😂

source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
JonRowe
JonRowe reviewed May 24, 2020
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting much closer to being done just need the mailbox bits!

source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
source/blog/2019-05-11-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
@benoittgt benoittgt marked this pull request as ready for review May 24, 2020 14:28
@benoittgt
Copy link
Member Author

I pushed the doc of rspec-rails on Relish with the change for ActionMailbox. Even if 4-0-maintenance have unreleased commits. They do not contains documentation.

@pirj
Copy link
Member

pirj commented May 24, 2020

Even if 4-0-maintenance have unreleased commits.

What's the guideline for maintenance branches? Does it mean it only has code that is pushed to RubyGems? Or only for the latest release? It's high time for 4.0.2 anyway :D

@benoittgt
Copy link
Member Author

Can we have access to https://github.com/RSpec-Staging/rspec-staging.github.io Jon?

JonRowe
JonRowe requested changes May 25, 2020
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review of the mailbox additions...

source/blog/2020-03-24-rspec-rails-4-0-has-been-released.md Outdated Show resolved Hide resolved
JonRowe
JonRowe approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this when you are, I might tweak it a bit before deploying.

@benoittgt
Copy link
Member Author

I am ok with the result. Thanks a lot for all your feedback and suggestions.

@JonRowe
Copy link
Member

JonRowe commented May 26, 2020

@benoittgt Are you ok to merge this then?

@benoittgt benoittgt merged commit 3a26f9a into source May 27, 2020
@benoittgt benoittgt deleted the rspec-rails-4-release branch May 27, 2020 09:45
@JonRowe
Copy link
Member

JonRowe commented May 27, 2020

Thanks @benoittgt I'll stage and release this today

@JonRowe
Copy link
Member

JonRowe commented May 27, 2020

Deployed! 🥳 🎉

@pirj
Copy link
Member

pirj commented May 27, 2020

Yay! 🎉

@benoittgt
Copy link
Member Author

Ouhao. Thanks for your multiple reviews! Champagne

@yujinakayama
Copy link
Member

#143 (comment)

@pirj Sorry for my late reply. I'll translate the post in a few days 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choosen choosen choosen left review comments

@pirj pirj pirj approved these changes

@JonRowe JonRowe JonRowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benoittgt @pirj @JonRowe @yujinakayama @choosen