-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bundle outdated
with both --groups
and --parseable
flags
#6148
Conversation
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @markburns! Other than the lint error, this seems fine. I'll merge this as soon as the lint error is fixed ❤️
3984086
to
3689526
Compare
Thanks @deivid-rodriguez. Should be fixed now. Ironically found it tricky setting up rubocop due to gem dependency issues. Just manually installed the dependencies now to get working locally. Curious if there's any way to use bundler to build bundler. |
bundle outdated
with both --groups
and --parseable
flags
3689526
to
3b0b95c
Compare
We do use a Gemfile to keep our development dependencies, and use Bundler to install them under the hood. You should run |
@deivid-rodriguez I see, yes that works fine now. I think it's a little unclear as that's at the top level of rubygems. I went and I managed to avoid seeing I would do a PR to improve the docs, but I am not sure I'm familiar enough yet with the process and setup to suggest it. |
To update docs just find out related "ronn" file (maybe this one https://github.com/rubygems/rubygems/blob/master/bundler/lib/bundler/man/bundle-outdated.1.ronn?), do the change, render it to the man format (using |
Thanks for the feedback and for this PR @markburns. I opened #6154 to improve our development setup docs. |
What was the end-user or developer problem that led to this PR?
The
bundle outdated
command blows up when combining--groups
and--parseable
optionsWhat is your fix for the problem, implemented in this PR?
Add a spec to replicate and fix the argument passed to the
print_gems
method.Explanation: it seems this behaviour was untested and broken.
Fixes #6147.
Make sure the following tasks are checked