Improve Bundler setup docs for development #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
deivid-rodriguez
force-pushed
the
add-rake-setup-to-bundler-setup
branch
from
0fef818
to
ae63fc2
Compare
This is battle tested enough now, and the only thing CI runs.
deivid-rodriguez
force-pushed
the
add-rake-setup-to-bundler-setup
branch
from
ae63fc2
to
d48b55a
Compare
hsbt
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
As pointed out by @markburns at #6148 (comment), contributors to Bundler may miss the
rake setupstep.What is your fix for the problem, implemented in this PR?
Add it to the proper place. Also, since I was at it, changed docs to recommend only the "parallel tests setup", since it's well battle tested now and the only thing CI runs.
Make sure the following tasks are checked