Optimistically exclude prereleases from initial resolution #6246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
prereleases
branch
2 times, most recently
from
b4f65bc
to
dd42a30
Compare
deivid-rodriguez
force-pushed
the
prereleases
branch
6 times, most recently
from
faede2e
to
0f4d6e8
Compare
deivid-rodriguez
force-pushed
the
prereleases
branch
from
0f4d6e8
to
312a2c8
Compare
deivid-rodriguez
force-pushed
the
prereleases
branch
from
312a2c8
to
e24bb9b
Compare
Only if we can't resolve without prereleases (if they have not been explicitly requested), try including them.
deivid-rodriguez
force-pushed
the
prereleases
branch
from
e24bb9b
to
7eae070
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 13, 2023
Optimistically exclude prereleases from initial resolution (cherry picked from commit 9abd8ac)
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Sometimes, resolution may end up choosing a prerelease version, but normally end users do not want prereleases at all, unless they explicitly request them.
What is your fix for the problem, implemented in this PR?
Do an optimistic first pass that resolves without prereleases. This should work in most cases, since normally resolutions don't need prereleases. Only if that fails, do a second pass considering prereleases.
This should also speed up most resolutions, since the search space is greatly reduced by default. As an example, Rails has 437 releases as of today, and 162 of them are prereleases.
Fixes #6226.
Make sure the following tasks are checked