Fix incorrect re-resolve messages #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the lockfile is correct both after `bundle install` and `bundle check`.
4 tasks
martinemde
approved these changes
Dec 19, 2023
deivid-rodriguez
pushed a commit
that referenced
this pull request
Dec 21, 2023
(cherry picked from commit efc224a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Sometimes bundler prints a message about re-resolving because of a gem it's missing from the lockfile, but it's one of its dependencies that's actually missing.
What is your fix for the problem, implemented in this PR?
Print a correct message when this happens.
Make sure the following tasks are checked