Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing: Fix SQLA query and type hints in get_evaluation_backlog #6552

Merged
merged 1 commit into from Mar 13, 2024
Merged

Typing: Fix SQLA query and type hints in get_evaluation_backlog #6552

merged 1 commit into from Mar 13, 2024

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Mar 13, 2024 •
edited

fixes #6550

@rdimaio rdimaio marked this pull request as ready for review March 13, 2024 11:24
dchristidis
dchristidis reviewed Mar 13, 2024
View reviewed changes
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
@rdimaio rdimaio force-pushed the scalars-fix branch 3 times, most recently from 5900441 to ffc57e7 Compare March 13, 2024 13:54
@rdimaio rdimaio changed the title Typing: Fix SQLA query in get_evaluation_backlog Typing: Fix SQLA query and type hints in get_evaluation_backlog Mar 13, 2024
dchristidis
dchristidis reviewed Mar 13, 2024
View reviewed changes
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
dchristidis
dchristidis approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@dchristidis dchristidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@rdimaio
Copy link
Contributor Author

rdimaio commented Mar 13, 2024

Thanks for the quick fix.

Thanks for the quick reviews!

@bari12 bari12 merged commit ec84fe0 into rucio:master Mar 13, 2024
27 of 28 checks passed
@dchristidis dchristidis mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchristidis dchristidis dchristidis approved these changes

@bari12 bari12 bari12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression from #6516
3 participants
@rdimaio @bari12 @dchristidis