Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split miscellaneous code into a new command_helpers module #931

Merged
merged 1 commit into from
Jan 29, 2024
Merged

split miscellaneous code into a new command_helpers module #931

merged 1 commit into from
Jan 29, 2024

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jan 29, 2024

No description provided.

@Be-ing Be-ing force-pushed the command_helpers branch 2 times, most recently from 8bacfcb to 47d5590 Compare January 29, 2024 05:38
NobodyXu
NobodyXu requested changes Jan 29, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@Be-ing Be-ing force-pushed the command_helpers branch 2 times, most recently from 3e7ab35 to 0c0bafe Compare January 29, 2024 08:08
NobodyXu
NobodyXu requested changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, it seems that you copied Build into src/build.rs, however there's no mod build; declaration anywhere in the diff.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 29, 2024 •
edited

BTW, it seems that you copied Build into src/build.rs, however there's no mod build; declaration anywhere in the diff.

Oops, I didn't intend to commit that in this PR. I am waiting for this, #924, and #929 to be merged before doing that. Fixed.

NobodyXu
NobodyXu approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NobodyXu NobodyXu merged commit bb48f58 into rust-lang:main Jan 29, 2024
18 checks passed
@Be-ing Be-ing deleted the command_helpers branch January 29, 2024 23:47
@amaanq amaanq mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Be-ing @NobodyXu