Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ioctl FS_IOC_* version and flag constants #3396

Merged
merged 1 commit into from Nov 14, 2023
Merged

Add ioctl FS_IOC_* version and flag constants #3396

merged 1 commit into from Nov 14, 2023

Conversation

fsavy-tehtris
Copy link
Contributor

This is a tentative to fix #3089 because the original author is unlikely to revisit it.

I've added the missing architectures for the constants on Linux, I think they should all be covered now.

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@JohnTitor
Copy link
Member

@bors r+
Thanks!

@bors
Copy link
Contributor

bors commented Oct 28, 2023

📌 Commit f62b8b5 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 28, 2023

⌛ Testing commit f62b8b5 with merge f0196cb...

bors added a commit that referenced this pull request Oct 28, 2023
@bors
Auto merge of #3396 - fsavy-tehtris:ioctl-flags, r=JohnTitor
f0196cb 
Add ioctl FS_IOC_* version and flag constants

This is a tentative to fix #3089 because the original author is unlikely to revisit it.

I've added the missing architectures for the constants on Linux, I think they should all be covered now.
@bors
Copy link
Contributor

bors commented Oct 28, 2023

💔 Test failed - checks-actions

@fsavy-tehtris
Copy link
Contributor Author

I've added the missing arm target_arch but I was not able to run the Android tests on my machine.

@rustbot review

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2023

📌 Commit d7a1f8b has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 31, 2023

⌛ Testing commit d7a1f8b with merge 1a8b4cc...

bors added a commit that referenced this pull request Oct 31, 2023
@bors
Auto merge of #3396 - fsavy-tehtris:ioctl-flags, r=JohnTitor
1a8b4cc 
Add ioctl FS_IOC_* version and flag constants

This is a tentative to fix #3089 because the original author is unlikely to revisit it.

I've added the missing architectures for the constants on Linux, I think they should all be covered now.
@bors
Copy link
Contributor

bors commented Oct 31, 2023

💔 Test failed - checks-actions

@fsavy-tehtris
Copy link
Contributor Author

More fixes.
@rustbot review

@JohnTitor
Copy link
Member

Could you squash commits into one?

@JohnTitor JohnTitor mentioned this pull request Nov 1, 2023
Closed
@fsavy-tehtris
Copy link
Contributor Author

Done!

@fsavy-tehtris
Copy link
Contributor Author

@rustbot review

@JohnTitor
Copy link
Member

Sorry for the delay, thanks! @bors r+

@bors
Copy link
Contributor

bors commented Nov 9, 2023

📌 Commit 8f8585e has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 9, 2023

⌛ Testing commit 8f8585e with merge c01a3aa...

bors added a commit that referenced this pull request Nov 9, 2023
@bors
Auto merge of #3396 - fsavy-tehtris:ioctl-flags, r=JohnTitor
c01a3aa 
Add ioctl FS_IOC_* version and flag constants

This is a tentative to fix #3089 because the original author is unlikely to revisit it.

I've added the missing architectures for the constants on Linux, I think they should all be covered now.
@bors
Copy link
Contributor

bors commented Nov 9, 2023

💔 Test failed - checks-actions

@fsavy-tehtris
Copy link
Contributor Author

I think I've fixed the outstanding issues with Android, although the linker does not work in the CI container.
The macOS check broke but I think this is because the related image was updated?

@rustbot review

@JohnTitor
Copy link
Member

Yeah, the macOS failure is unrelated and has been fixed on main. Let's give another try!
@bors r+

@bors
Copy link
Contributor

bors commented Nov 14, 2023

📌 Commit e76c2be has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 14, 2023

⌛ Testing commit e76c2be with merge 78a3d13...

@bors
Copy link
Contributor

bors commented Nov 14, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 78a3d13 to main...

@bors bors merged commit 78a3d13 into rust-lang:main Nov 14, 2023
10 of 11 checks passed
@sunfishcode sunfishcode mentioned this pull request Nov 14, 2023
Closed
@fsavy-tehtris fsavy-tehtris deleted the ioctl-flags branch November 15, 2023 08:04
@fsavy-tehtris fsavy-tehtris mentioned this pull request Dec 15, 2023
Merged
@heiher heiher mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fsavy-tehtris @rustbot @JohnTitor @bors