New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop testing on FreeBSD 12 #3475
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,3 @@ | ||
task: | ||
name: nightly x86_64-unknown-freebsd-12 | ||
freebsd_instance: | ||
image_family: freebsd-12-4 | ||
setup_script: | ||
- pkg install -y libnghttp2 curl | ||
- curl https://sh.rustup.rs -sSf --output rustup.sh | ||
- sh rustup.sh --default-toolchain nightly -y --profile=minimal | ||
- . $HOME/.cargo/env | ||
test_script: | ||
- . $HOME/.cargo/env | ||
- LIBC_CI=1 sh ci/run.sh x86_64-unknown-freebsd | ||
- sh ci/run.sh x86_64-unknown-freebsd | ||
|
||
task: | ||
name: nightly x86_64-unknown-freebsd-13 | ||
freebsd_instance: | ||
|
@@ -29,7 +15,7 @@ task: | |
task: | ||
name: nightly x86_64-unknown-freebsd-14 | ||
freebsd_instance: | ||
image: freebsd-14-0-rc1-amd64 | ||
image: freebsd-14-0-release-amd64-ufs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. now there is a proper 14 release, |
||
setup_script: | ||
- pkg install -y libnghttp2 curl | ||
- curl https://sh.rustup.rs -sSf --output rustup.sh | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it s tricky ... logically you re right but in the wild there are many users still taking time to migrate (in another project I had a freebsd ... 9.2 user, a bit extreme :) but you get me ..). I may suggest to give a bit of time before removing it but not up to me..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9.2? Wow. My feeling is that while some users may take some time to upgrade, they also probably aren't using cutting edge Rust software. So those users can probably make do with older crates. No need to maintain the latest Rust releases for old FreeBSD release. At least, that's my philosophy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. It seems it takes more than this tough see what it took for freebsd 11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that removing CI doesn't mean that the existing usage on FreeBSD 12 will be broken. The impact of this should be low, I think.