-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crates.io-index repository under automation #1306
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Eric Huss <eric@huss.org>
it usually doesn't, but there have been cases where the crates.io team has opened a PR to manually fix something |
I totally agree that it is weird, and IMHO we should change it eventually. The crates.io backend is pushing to the repository with a deploy SSH key (AFAIK) and uses git author information (i.e. email) to associate the commits to the bors GH account. those are not signed commits though, so anyone basically can create commits like that, just not necessarily in this repo. to answer the initial question: no, bors does not need access to this repository. |
[[branch-protections]] | ||
pattern = "master" | ||
required-approvals = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless I'm missing something, the pr-required = false
from the PR text seems quite important here, since the crates.io backend is pushing directly to the master branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. The issue is that pr-required
is not implemented yet 😆
Repo: https://github.com/rust-lang/crates.io-index
I'm pretty sure that this isn't correct yet. This repo should most probably not require PRs. Should I add bors to it? It's not managed by
homu
, but the bors GH account pushes to the repo regularly (even though it seems like it didn't have access?!), this is quite weird.Extracted from GH: