Add the option to not require a PR for protected branches #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
branch-protection-mode
branch
from
132af34
to
0c68f45
Compare
Turbo87
reviewed
Feb 28, 2024
rylev
reviewed
Mar 4, 2024
rylev
reviewed
Mar 19, 2024
Kobzol
force-pushed
the
branch-protection-mode
branch
from
0c68f45
to
81651f2
Compare
|
The |
jackh726
reviewed
May 20, 2024
| @@ -43,11 +47,15 @@ | |||
| "branch_protections": [ | |||
| { | |||
| "pattern": "master", | |||
| "ci_checks": [ | |||
There was a problem hiding this comment.
This change breaks anything (namely sync-team) that relies on the current schema?
Don't think we can do this (at least not immediately).
There was a problem hiding this comment.
I don't think that there's anything else than sync-team that read the branch protections, and the sync-team change is ready. I already did some breaking changes recently that broke sync-team, it doesn't seem like a big deal.
Although, it would be bad if this broke other tools that just reuse the schema, even if they don't read the branch protections at all. Not sure if there are any of these though. Is there even any other tool apart from sync-team that reads the repos endpoint?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
pr-required = <true/false>option to branch protections. There are some repositories that use branch protections, but that do not require a PR.I also refactored the branch protection mode to make the data representation clearer/make it impossible to represent invalid states (such as PR not required, but a required approval count is set). This is a compatibility break for the v1 data format, but branch protections are only read by
sync-teamanyway, so it shouldn't be a big deal.An interesting thing is that it does not actually make sense to require any CI status checks if a PR is not required, because we do not enable anyone to bypass the branch protections. Because if you set a CI check, and try to push to the branch without a PR, it will be rejected.
Without a required PR, the branch protection still disallows force pushes and deletion, and allows us to set push actor allowances.
Relevant repos: