Remove requirement to create PRs from calendar repo #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtwco
approved these changes
Feb 29, 2024
traviscross
force-pushed
the
TC/remove-branch-protection-on-calendar-repo
branch
from
5817096
to
8512330
Compare
The calendar repository is used to maintain the calendar events for various teams. For some teams, it's important that the friction for adding or updating calendar events be low, as otherwise team members start looking for or using alternate calendaring solutions. Keeping this friction as low as possible is probably more important, in this case, than the benefits that we're getting from requiring PRs as part of the branch protection. So let's remove that requirement. The other option here would be to instead add `required-approvals = 0` to the branch protection. This would require creating PRs but would avoid the need for a separate reviewer. This is an option, but it would still increase the friction a bit, and it therefore seems net-better to just remove the need to create PRs. Many other repositories here operate without branch protection at all without that creating any substantial problems. In cases where someone thinks that something deserves a PR, e.g. so it can be discussed, that person can still of course create one. But we don't need to require it. For a calendar, the speed at which it can be updated is often the most important property.
traviscross
force-pushed
the
TC/remove-branch-protection-on-calendar-repo
branch
from
8512330
to
b133df2
Compare
traviscross
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calendar repository is used to maintain the calendar events for various teams.
For some teams, it's important that the friction for adding or updating calendar events be low, as otherwise team members start looking for or using alternate calendaring solutions. Keeping this friction as low as possible is probably more important, in this case, than the benefits that we're getting from requiring PRs as part of the branch protection. So let's remove that requirement.
The other option here would be to instead add
required-approvals = 0to the branch protection. This would require creating PRs but would avoid the need for a separate reviewer.This is an option, but it would still increase the friction a bit, and it therefore seems net-better to just remove the need to create PRs. Many other repositories here operate without branch protection at all without that creating any substantial problems. In cases where someone thinks that something deserves a PR, e.g. so it can be discussed, that person can still of course create one. But we don't need to require it.
For a calendar, the speed at which it can be updated is often the most important property.