Use cfg(panic = unwind) instead of a check for wasm32 to see if unwinding is supported #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding is supported This allows the test to run on a future wasm target with exception support as well as running the test suite with panic=abort on non-wasm targets.
|
This would allow removing the https://github.com/bjorn3/rustc_codegen_cranelift/blob/b49adfeea512dde803222a063c8f079346fbfda5/patches/0002-rand-Disable-failing-test.patch patch for testing rand with cg_clif. |
|
Looks like this is not yet available for the MSRV (1.56). It is only available starting from 1.60. It is a test, not something that would get compiled when using it as dependency, so maybe that is fine? |
|
Honestly, upgrading to 1.60 should be fine. |
|
Pushed a commit to update the MSRV. |
bjorn3
force-pushed
the
panic_abort_test
branch
from
678620a
to
b6e92fb
Compare
|
Regarding the remaining CI failure, you can replace |
dhardy
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the test to run on a future wasm target with exception support as well as running the test suite with panic=abort on non-wasm targets.