chore: udpate deps #3520
chore: udpate deps #3520
Conversation
| "eslint-plugin-import": "^2.27.5", | ||
| "eslint-plugin-jest": "^27.1.7", | ||
| "fs-extra": "^11.1.1", | ||
| "glob": "^9.3.1", | ||
| "glob": "^10.2.5", |
There was a problem hiding this comment.
I checked, the breaking change is to remove the default export (isaacs/node-glob@26673b9), looks like we aren't using it anywhere anymore.
| @@ -29,7 +29,7 @@ | |||
| "@lwc/rollup-plugin-node-resolve-legacy": "npm:rollup-plugin-node-resolve@5.2.0", | |||
| "folder-hash": "4.0.4", | |||
| "markdown-table": "^3.0.3", | |||
| "tachometer": "0.5.10" | |||
| "tachometer": "0.7.0" | |||
There was a problem hiding this comment.
We can't upgrade Tachometer. See the note above:
lwc/packages/@lwc/perf-benchmarks/package.json
Lines 15 to 16 in 5a6188e
| ['autofocus', new Set(['button', 'input', 'keygen', 'select', 'textarea'])], | ||
| ['autoplay', new Set(['audio', 'video'])], | ||
| ['checked', new Set(['command', 'input'])], | ||
| const BOOLEAN_ATTRIBUTES = /*@__PURE__@*/ new Map([ |
There was a problem hiding this comment.
Needed because rollup started marking Map, Set etc. as impure. rollup/rollup#4955
We could mark Map, Set as pure in rollup.config.js, but that would be on the consumer to do, and if they, for some reason, don't do it, these are not tree-shaken.
There was a problem hiding this comment.
Interesting! Great find. Looks like they're marking all Maps/Sets as impure as a temporary fix for rollup/rollup#4282 . In any case, we can keep the /*@__PURE__@*/ permanently to play it safe.
|
/nucleus ignore -m "broken check in downstream" |
Details
Update dependencies
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item