Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: udpate deps #3520

Merged
merged 3 commits into from
May 19, 2023
Merged

chore: udpate deps #3520

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7629572
chore: udpate deps
abdulsattar May 19, 2023
a85bee8
fix: mark Set and Map uses as PURE
abdulsattar May 19, 2023
8632420
fix: revert tachometer upgrade
abdulsattar May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 14 additions & 14 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,43 +27,43 @@
"release:version": "./scripts/release/version.js"
},
"devDependencies": {
"@babel/core": "^7.21.4",
"@babel/preset-env": "^7.21.4",
"@babel/core": "^7.21.8",
"@babel/preset-env": "^7.21.5",
"@commitlint/cli": "^17.5.1",
"@lwc/eslint-plugin-lwc-internal": "link:./scripts/eslint-plugin",
"@lwc/jest-utils-lwc-internals": "link:./scripts/jest/utils",
"@rollup/plugin-commonjs": "^25.0.0",
"@rollup/plugin-inject": "^5.0.3",
"@rollup/plugin-node-resolve": "^15.0.2",
"@rollup/plugin-replace": "^5.0.2",
"@rollup/plugin-typescript": "^11.1.0",
"@rollup/plugin-typescript": "^11.1.1",
"@types/babel__core": "^7.20.0",
"@types/glob": "^8.1.0",
"@types/jest": "^29.5.0",
"@types/node": "^18.15.11",
"@typescript-eslint/eslint-plugin": "^5.58.0",
"@typescript-eslint/parser": "^5.58.0",
"@types/jest": "^29.5.1",
"@types/node": "^20.2.1",
"@typescript-eslint/eslint-plugin": "^5.59.6",
"@typescript-eslint/parser": "^5.59.6",
"bytes": "^3.1.2",
"es5-proxy-compat": "^0.22.4",
"eslint": "^8.38.0",
"eslint": "^8.40.0",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-jest": "^27.1.7",
"fs-extra": "^11.1.1",
"glob": "^9.3.1",
"glob": "^10.2.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, the breaking change is to remove the default export (isaacs/node-glob@26673b9), looks like we aren't using it anywhere anymore.

"husky": "^8.0.2",
"is-ci": "^3.0.1",
"isbinaryfile": "^5.0.0",
"jest": "^29.5.0",
"jest-environment-jsdom": "^29.5.0",
"lint-staged": "^13.2.1",
"lint-staged": "^13.2.2",
"magic-string": "^0.30.0",
"nx": "15.9.2",
"prettier": "^2.8.7",
"rollup": "^3.20.2",
"prettier": "^2.8.8",
"rollup": "^3.22.0",
"rollup-plugin-compat": "^0.22.4",
"terser": "^5.16.9",
"terser": "^5.17.4",
"ts-jest": "^29.1.0",
"tslib": "^2.5.0",
"tslib": "^2.5.2",
"typescript": "5.0.4",
"workerpool": "^6.4.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@lwc/compiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
}
},
"dependencies": {
"@babel/core": "~7.21.4",
"@babel/core": "~7.21.8",
"@babel/plugin-proposal-class-properties": "~7.18.6",
"@babel/plugin-proposal-object-rest-spread": "~7.20.2",
"@lwc/babel-plugin-component": "2.45.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/@lwc/integration-karma/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"istanbul-lib-coverage": "^3.2.0",
"istanbul-lib-report": "^3.0.0",
"istanbul-reports": "^3.1.5",
"karma": "^6.4.1",
"karma-chrome-launcher": "^3.1.0",
"karma": "^6.4.2",
"karma-chrome-launcher": "^3.2.0",
"karma-coverage": "^2.2.0",
"karma-jasmine": "^4.0.2",
"karma-sauce-launcher": "^4.3.6",
Expand Down
2 changes: 1 addition & 1 deletion packages/@lwc/perf-benchmarks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@lwc/rollup-plugin-node-resolve-legacy": "npm:rollup-plugin-node-resolve@5.2.0",
"folder-hash": "4.0.4",
"markdown-table": "^3.0.3",
"tachometer": "0.5.10"
"tachometer": "0.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't upgrade Tachometer. See the note above:

lwc/packages/@lwc/perf-benchmarks/package.json

Lines 15 to 16 in 5a6188e

"Also note we are pinned to Tachometer 0.5.10 due to a breaking change in 0.6.0.",
"Breaking change: https://github.com/google/tachometer/issues/244",

},
"nx": {
"targets": {
Expand Down
2 changes: 1 addition & 1 deletion packages/@lwc/shared/src/aria.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export function isAriaAttribute(attrName: string): boolean {

// These attributes take either an ID or a list of IDs as values.
// This includes aria-* attributes as well as the special non-ARIA "for" attribute
export const ID_REFERENCING_ATTRIBUTES_SET: Set<string> = new Set([
export const ID_REFERENCING_ATTRIBUTES_SET: Set<string> = /*@__PURE__*/ new Set([
'aria-activedescendant',
'aria-controls',
'aria-describedby',
Expand Down
39 changes: 20 additions & 19 deletions packages/@lwc/shared/src/html-attributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ const CAMEL_REGEX = /-([a-z])/g;
* Maps boolean attribute name to supported tags: 'boolean attr name' => Set of allowed tag names
* that supports them.
*/
const BOOLEAN_ATTRIBUTES = new Map([
['autofocus', new Set(['button', 'input', 'keygen', 'select', 'textarea'])],
['autoplay', new Set(['audio', 'video'])],
['checked', new Set(['command', 'input'])],
const BOOLEAN_ATTRIBUTES = /*@__PURE__@*/ new Map([
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed because rollup started marking Map, Set etc. as impure. rollup/rollup#4955

We could mark Map, Set as pure in rollup.config.js, but that would be on the consumer to do, and if they, for some reason, don't do it, these are not tree-shaken.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Great find. Looks like they're marking all Maps/Sets as impure as a temporary fix for rollup/rollup#4282 . In any case, we can keep the /*@__PURE__@*/ permanently to play it safe.

['autofocus', /*@__PURE__@*/ new Set(['button', 'input', 'keygen', 'select', 'textarea'])],
['autoplay', /*@__PURE__@*/ new Set(['audio', 'video'])],
['checked', /*@__PURE__@*/ new Set(['command', 'input'])],
[
'disabled',
new Set([
/*@__PURE__@*/ new Set([
'button',
'command',
'fieldset',
Expand All @@ -30,17 +30,18 @@ const BOOLEAN_ATTRIBUTES = new Map([
'textarea',
]),
],
['formnovalidate', new Set(['button'])], // button[type=submit]
['hidden', new Set()], // Global attribute
['loop', new Set(['audio', 'bgsound', 'marquee', 'video'])],
['multiple', new Set(['input', 'select'])],
['muted', new Set(['audio', 'video'])],
['novalidate', new Set(['form'])],
['open', new Set(['details'])],
['readonly', new Set(['input', 'textarea'])],
['required', new Set(['input', 'select', 'textarea'])],
['reversed', new Set(['ol'])],
['selected', new Set(['option'])],
['formnovalidate', /*@__PURE__@*/ new Set(['button'])], // button[type=submit]
['hidden', /*@__PURE__@*/ new Set()], // Global attribute
['loop', /*@__PURE__@*/ new Set(['audio', 'bgsound', 'marquee', 'video'])],
['multiple', /*@__PURE__@*/ new Set(['input', 'select'])],
['muted', /*@__PURE__@*/ new Set(['audio', 'video'])],
['novalidate', /*@__PURE__@*/ new Set(['form'])],
['open', /*@__PURE__@*/ new Set(['details'])],
['readonly', /*@__PURE__@*/ new Set(['input', 'textarea'])],
['readonly', /*@__PURE__@*/ new Set(['input', 'textarea'])],
['required', /*@__PURE__@*/ new Set(['input', 'select', 'textarea'])],
['reversed', /*@__PURE__@*/ new Set(['ol'])],
['selected', /*@__PURE__@*/ new Set(['option'])],
]);

export function isBooleanAttribute(attrName: string, tagName: string): boolean {
Expand All @@ -52,7 +53,7 @@ export function isBooleanAttribute(attrName: string, tagName: string): boolean {
}

// This list is based on https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes
const GLOBAL_ATTRIBUTE = new Set([
const GLOBAL_ATTRIBUTE = /*@__PURE__*/ new Set([
'accesskey',
'autocapitalize',
'autofocus',
Expand Down Expand Up @@ -130,12 +131,12 @@ const { NO_STANDARD_ATTRIBUTE_PROPERTY_MAPPING, NO_STANDARD_PROPERTY_ATTRIBUTE_M
/**
* Map associating previously transformed HTML property into HTML attribute.
*/
const CACHED_PROPERTY_ATTRIBUTE_MAPPING = new Map<string, string>();
const CACHED_PROPERTY_ATTRIBUTE_MAPPING = /*@__PURE__@*/ new Map<string, string>();

/**
* Map associating previously transformed HTML attribute into HTML property.
*/
const CACHED_ATTRIBUTE_PROPERTY_MAPPING = new Map<string, string>();
const CACHED_ATTRIBUTE_PROPERTY_MAPPING = /*@__PURE__@*/ new Map<string, string>();

export function htmlPropertyToAttribute(propName: string): string {
const ariaAttributeName = AriaPropNameToAttrNameMap[propName];
Expand Down
6 changes: 3 additions & 3 deletions packages/@lwc/shared/src/void-elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { HTML_NAMESPACE } from './namespaces';
// e.g. `</tagName>` or `<tagName />`. For instance, `<meta>` closes on its own; no need for a slash.
// These only come from HTML; there are no void elements in the SVG or MathML namespaces.
// See: https://html.spec.whatwg.org/multipage/syntax.html#syntax-tags
const VOID_ELEMENTS = [
const VOID_ELEMENTS = /*@__PURE__*/ [
'area',
'base',
'br',
Expand All @@ -30,9 +30,9 @@ const VOID_ELEMENTS = [
// These elements have been deprecated but preserving their usage for backwards compatibility
// until we can officially deprecate them from LWC.
// See: https://html.spec.whatwg.org/multipage/obsolete.html#obsolete-but-conforming-features
const DEPRECATED_VOID_ELEMENTS = ['param', 'keygen', 'menuitem'];
const DEPRECATED_VOID_ELEMENTS = /*@__PURE__*/ ['param', 'keygen', 'menuitem'];

const VOID_ELEMENTS_SET = new Set([...VOID_ELEMENTS, ...DEPRECATED_VOID_ELEMENTS]);
const VOID_ELEMENTS_SET = /*@__PURE__*/ new Set([...VOID_ELEMENTS, ...DEPRECATED_VOID_ELEMENTS]);

export function isVoidElement(name: string, namespace: string): boolean {
return namespace === HTML_NAMESPACE && VOID_ELEMENTS_SET.has(name.toLowerCase());
Expand Down
4 changes: 2 additions & 2 deletions packages/@lwc/style-compiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
},
"dependencies": {
"@lwc/shared": "2.45.2",
"postcss": "~8.4.20",
"postcss-selector-parser": "~6.0.11",
"postcss": "~8.4.23",
"postcss-selector-parser": "~6.0.13",
"postcss-value-parser": "~4.2.0",
"string.prototype.matchall": "^4.0.8"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@lwc/template-compiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"parse5": "~6.0.1"
},
"devDependencies": {
"@types/estree": "1.0.0",
"@types/estree": "1.0.1",
"@types/he": "^1.2.0",
"@types/parse5": "^6.0.2",
"@types/source-map": "0.5.7"
Expand Down
2 changes: 1 addition & 1 deletion playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@lwc/rollup-plugin": "2.45.2",
"@rollup/plugin-replace": "^5.0.2",
"lwc": "2.45.2",
"rollup": "^3.20.2",
"rollup": "^3.22.0",
"rollup-plugin-livereload": "^2.0.5",
"rollup-plugin-serve": "^2.0.2"
},
Expand Down