Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pin chromedriver version #3897

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Conversation

nolanlawson
Copy link
Contributor

Details

Fixes #3852

Pins chromedriver to the same version of Chrome we are currently using in the Tachometer benchmark smoke tests.

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Fixes #3852
@nolanlawson nolanlawson requested a review from a team as a code owner December 11, 2023 21:03

Verified

This commit was signed with the committer’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
@nolanlawson nolanlawson merged commit b58f710 into master Dec 11, 2023
@nolanlawson nolanlawson deleted the nolan/pin-chromedriver branch December 11, 2023 21:27
nolanlawson added a commit that referenced this pull request Dec 21, 2023

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Fixes #3852
nolanlawson added a commit that referenced this pull request Dec 21, 2023

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark smoke tests should pin the chromedriver and Chrome versions
2 participants