New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: add codecov #1014
infra: add codecov #1014
Conversation
998fa63
to
e549c2b
Compare
e549c2b
to
597c097
Compare
@goce-cz there should be a request to add codecov in github for this project. |
@coffeeowl @dprentis @matthewgertner @oilart somehow @goce-cz is not responding anymore :( can someone of you help me with that? either grant me a bit more permission, or lets try to get codecov working by one of you accepting the token |
@goce-cz is really busy these days, sorry. TBH I don't feel like installing further 3rd party tools into our workspace because of the library. Is this one really critical? |
Nothing of that is really "critical", but the current workaround approach using GitHub Actions (see #1015) lacks the feature of successfully running PR coverage reports from community contribution PR from forks. At FakerJS we are really happy with Codecov, see https://app.codecov.io/gh/faker-js/faker for example. The process to setup Codecov should be really straight forward and as far as I know, only the token needs to be one time written by members with higher permission (https://docs.codecov.com/docs/quick-start#step-2-get-the-repository-upload-token). I understand that external services are mostly not needed anymore, as I also replaced all stuff related CircleCI with GitHub Actions. But Codecov is right now the best choice I know. |
|
No description provided.