-
Notifications
You must be signed in to change notification settings - Fork 121
recompile downstream when Java annotation changes #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jason thinks the approach sounds good and notes,
|
68b4ee8
to
5ffb3a0
Compare
760b1d1
to
95b33e4
Compare
My initial implementation temporarily, kludgily overloaded the The theme for today was to figure out what to do instead. I initially assumed that I would need to add an But after discussion with @dwijnand and @retronym, we decided that would be overkill. We suspect that the But here the situation is simpler, so they suggested we could just have And that approach seems to be working out. |
I think this is ready to go, but there's a customer that might like to test it before merge. |
@dwijnand I've review-requested you, but also, do you think there's anyone else who should or might like to take a look? |
(rebased, without any changes) |
I discovered that ParserSpecification was only testing that the Parser returned a non-null result, but that wasn't enough to fully exercise the parser; the annotations parser, for example, doesn't kick in unless you call `types` on the result. so let's do that.
I am gonna merge this so it'll be part of 1.7.0. |
regression report at sbt/sbt#6969 — I'll work on a fix pronto |
* fixes sbt/sbt#6969 * sequel to sbt#1079
* fixes sbt/sbt#6969 * sequel to sbt#1079
* fixes sbt/sbt#6969 * sequel to sbt#1079
* fixes sbt/sbt#6969 * sequel to sbt#1079
* fixes sbt/sbt#6969 * sequel to sbt#1079
* fixes sbt/sbt#6969 * sequel to sbt#1079
fixes #630