Address new warnings with the strict patmat exhaustivity of 2.13.4. #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring avoids having two similar matches, the second one depending on the first one. We also factor out the pattern that adds a code path to `callStatement` as `addCodePath`.
In 2.13.4, the pattern match exhaustivity analysis has become much stricter. It remains active in the presence of non-sealed classes, guards, and custom extractors. This change causes a lot of new warnings in our codebase. See scala/scala#9140 We address most warnings with `@unchecked`, but for some we throw more specialized exceptions instead.
|
At the Dotty meeting today, the changes in 2.13 were challenged by Martin, so we should wait for a resolution of that before merging here. |
|
Looks it might become non-default: scala/scala#9299 |
|
Superseded by #4276. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.13.4, the pattern match exhaustivity analysis has become much stricter. It remains active in the presence of non-sealed classes, guards, and custom extractors. This change causes a lot of new warnings in our codebase.
See scala/scala#9140
We address most warnings with
@unchecked, but for some we throw more specialized exceptions instead.Locally tested with