Catch up with Scala 2.13.4 #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implicit conversion in `Predef` was made non-implicit in Scala 2.13.4, because of issues on JDK15+. We could explicitly call it, but the recommended replacement is to use `CharBuffer.wrap`.
In 2.13.4, the pattern match exhaustivity analysis has become stricter. It remains active in the presence of guards and custom extractors (including `unapplySeq`). This change causes some new warnings in our codebase, which this commit addresses. See scala/scala#9140, which was somewhat toned down by scala/scala#9299.
Something seems to have changed in Scala 2.13.4 that optimizes `match`es whose scrutinee is a literal, causing two (similar) tests to fail. Since the literal scrutinee was not the point of those tests, we move it to another `def`.
sjrd
force-pushed
the
catch-up-with-2.13.4
branch
from
134dd9e
to
22a12c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CharBuffer.wrapto get aCharSequencefrom anArray[Char].MatchASTTestfor Scala 2.13.4.Supersedes #4272 now that scala/scala#9299 upstream tuned down most of the warnings. Also address two other incompatibilities with 2.13.4.
Locally tested with