[nomerge] Upgrade to asm 9.4, for JDK20 support #10185
Conversation
|
I've been swamped in recent weeks, but now that the 2.13.10 dust has settled I do intend to get back to this. |
SethTisue
force-pushed
the
update/asm9.4-scala212
branch
from
311b036
to
f5e02c8
Compare
|
I manually tested this by installing a JDK 20 early access build on my Mac (with (I also had to temporarily remove the call to |
what I mean is, it does at least as well as we were doing before on JDK 19, and that's the ambition level here. here on 2.12.x we don't have as many tests passing on JDK 18+ as we do over in the 2.13.x branch (thanks to the efforts of @som-snytt and others) |
|
Thank you Philippus! |
scala 2.12.x PR: scala/scala#10185 scala 2.13.x PR: scala/scala#10184
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.12.18 - https://www.scala-lang.org/news/2.12.18 ### Why are the changes needed? This release adds support for JDK 20 and 21: - scala/scala#10185 - scala/scala#10362 - scala/scala#10397 - scala/scala#10400 The full release notes as follows: - https://github.com/scala/scala/releases/tag/v2.12.18 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? Existing Test Closes #41627 from LuciferYang/SPARK-43832. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.12.18 - https://www.scala-lang.org/news/2.12.18 ### Why are the changes needed? This release adds support for JDK 20 and 21: - scala/scala#10185 - scala/scala#10362 - scala/scala#10397 - scala/scala#10400 The full release notes as follows: - https://github.com/scala/scala/releases/tag/v2.12.18 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? Existing Test Closes apache#41627 from LuciferYang/SPARK-43832. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
nomerge, because there's a separate 2.13.x PR: #10184.There's first some work to be done in https://github.com/scala/scala-asm.