Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbt-vspp for publishing the BLOOP SBT plug-in in a Maven-consistent format #1766

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

ScalaWilliam
Copy link
Contributor

This is to enable usage of Bloop/Metals in Enterprise environments where only the valid-POM format is accepted for JAR downloads (meaning most SBT plug-ins don't work -- currently making Scala unusable from VS Code at organizations with stricter security policies), for thousands of developers.

--

How this is tested locally:

publishM2, then in the target project that uses sbt-bloop, in its project/metals.sbt add, e.g.:

libraryDependencies += "ch.epfl.scala" % "sbt-bloop_2.12_1.0" % "1.5.2-13-15ded987-20220726-1436"
// only needed if published to local .m2 via publishM2
resolvers += Resolver.mavenLocal

More background here - https://github.com/esbeetee/sbt-vspp - more than happy to hop on a video call to discuss - as I appreciate that this is a non-issue for those that have a direct connection to Maven Central.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mback2k Marc Hörsken
This is to enable usage of Bloop/Metals in Enterprise environments where only the valid-POM format is accepted for JAR downloads (meaning most SBT plug-ins don't work -- currently making Scala unusable from VS Code at organizations with stricter security policies), for thousands of developers.

--

How this is tested locally:

`publishM2`, then in the target project that uses sbt-bloop, in its `project/metals.sbt` add, e.g.:

```
libraryDependencies += "ch.epfl.scala" % "sbt-bloop_2.12_1.0" % "1.5.2-13-15ded987-20220726-1436"
// only needed if published to local .m2 via publishM2
resolvers += Resolver.mavenLocal
```
@dos65
Copy link
Collaborator

dos65 commented Jul 26, 2022

@ScalaWilliam Thanks for the contribution!

I went trough all attached info and original issue in sbt - didn't know about this issue 😅
I'm wondering what sbt mantainers think about this approach. If it's valid one maybe it would be better just to include right it into sbt and all plugin will start supporting this scheme after sbt upgrade.

@tgodzik
Copy link
Contributor

tgodzik commented Jul 26, 2022

@ScalaWilliam Thanks for the contribution!

I went trough all attached info and original issue in sbt - didn't know about this issue sweat_smile I'm wondering what sbt mantainers think about this approach. If it's valid one maybe it would be better just to include right it into sbt and all plugin will start supporting this scheme after sbt upgrade.

Yeah, I am kind of curious what it's not being done by default 🤔 I am totally ok with merging, just I am surprised it's not being handled properly in the first place.

@dos65
Copy link
Collaborator

dos65 commented Jul 26, 2022

@adpi2 Could you take a look at this? Is there any chance that it will be ported to sbt?

@tgodzik
Copy link
Contributor

tgodzik commented Jul 28, 2022

Let's merge it an see if it works correctly in Metals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants