don't override JAVA_HOME env variable
#1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Mar 14, 2024
| @@ -40,7 +40,6 @@ export function getJavaConfig({ | |||
| const extraEnv = { | |||
| ...coursierRepositories, | |||
| ...coursierMirrors, | |||
| JAVA_HOME: javaHome, | |||
There was a problem hiding this comment.
Maybe we should still set it if not available?
There was a problem hiding this comment.
It shouldn't be needed, since we always fallback to checking system properties java home.
There was a problem hiding this comment.
We can change that if it turns out to be a problem sure
tgodzik
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected to: scalameta/metals#6204