Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't override JAVA_HOME env variable #1472

Merged
merged 1 commit into from Mar 15, 2024
Merged

don't override JAVA_HOME env variable #1472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/metals-languageclient/src/getJavaConfig.ts
View file
Open in desktop
Expand Up @@ -40,7 +40,6 @@ export function getJavaConfig({
const extraEnv = {
...coursierRepositories,
...coursierMirrors,
JAVA_HOME: javaHome,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should still set it if not available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be needed, since we always fallback to checking system properties java home.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change that if it turns out to be a problem sure

};

return {
Expand Down