Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse skipped frames #6240

Merged
merged 4 commits into from Mar 26, 2024
Merged

Collapse skipped frames #6240

merged 4 commits into from Mar 26, 2024

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Mar 21, 2024 •
edited

Use presentationHint to deemphasize/collapse skipped frames.

image

@adpi2 adpi2 force-pushed the deemphasize-skipped-frames branch from 628c4c7 to b52c8f6 Compare March 25, 2024 09:38
@adpi2 adpi2 requested a review from tgodzik March 25, 2024 09:38
@adpi2 adpi2 enabled auto-merge (rebase) March 25, 2024 09:38
@adpi2 adpi2 force-pushed the deemphasize-skipped-frames branch from dfd7051 to 3e1610f Compare March 25, 2024 14:04
@tgodzik
Copy link
Contributor

tgodzik commented Mar 25, 2024

Could you also run sbt scalafixAll or just order the imports in the file that you added them?

@adpi2 @tgodzik
Apply suggestions from code review
f2b270e 
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
@adpi2 adpi2 force-pushed the deemphasize-skipped-frames branch from 3e1610f to f2b270e Compare March 26, 2024 08:23
@adpi2 adpi2 requested a review from tgodzik March 26, 2024 08:24
tgodzik
tgodzik approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

@adpi2 adpi2 merged commit 00072f6 into scalameta:main Mar 26, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adpi2 @tgodzik