Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InternalTrees: don't keep token cache per tree #3652

Merged
merged 1 commit into from Mar 16, 2024
Merged

InternalTrees: don't keep token cache per tree #3652

merged 1 commit into from Mar 16, 2024

Conversation

kitbellew
Copy link
Contributor

@kitbellew kitbellew commented Mar 16, 2024 •
edited

There's already a token cache per input, so this is excessive and unnecessary. First introduced in #3484. Fixes #3650.

@kitbellew
InternalTrees: don't keep token cache per tree
e5f99af 
There's already a token cache per input, so this is excessive and
unnecessary. First introduced in scalameta#3484.
@kitbellew kitbellew requested a review from tgodzik March 16, 2024 11:36
@kitbellew kitbellew mentioned this pull request Mar 16, 2024
Closed
tgodzik
tgodzik approved these changes Mar 16, 2024
View reviewed changes
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix the issue raised I think, we can close the other PR

@kitbellew kitbellew merged commit f2111c6 into scalameta:main Mar 16, 2024
24 checks passed
@kitbellew kitbellew deleted the 3650_1 branch March 16, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OutOfMemoryError since 4.9.0
2 participants
@kitbellew @tgodzik