Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InternalTrees: don't keep token cache per tree #3652

Merged
merged 1 commit into from Mar 16, 2024
Merged

InternalTrees: don't keep token cache per tree #3652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 1 addition & 9 deletions scalameta/trees/shared/src/main/scala/scala/meta/internal/trees/InternalTrees.scala
View file
Open in desktop
Expand Up @@ -2,9 +2,7 @@ package scala.meta
package internal
package trees

import scala.collection.mutable
import scala.meta.inputs._
import scala.meta.internal.tokenizers.Compat
import scala.meta.internal.prettyprinters.TreeSyntax
import scala.meta.tokenizers._
import scala.meta.tokens._
Expand Down Expand Up @@ -66,13 +64,7 @@ trait InternalTree extends Product {
}

def tokenizeFor(dialect: Dialect): Tokens =
if (origin.dialectOpt.contains(dialect)) tokensOpt.get else lookupOrTokenizeFor(dialect)

private val tokenCache: mutable.Map[Dialect, Tokens] =
Compat.newMutableMap[Dialect, Tokens]

private def lookupOrTokenizeFor(dialect: Dialect): Tokens =
tokenCache.getOrElseUpdate(dialect, tokenizeForDialect(dialect))
if (origin.dialectOpt.contains(dialect)) tokensOpt.get else tokenizeForDialect(dialect)

private lazy val tokensOpt: Option[Tokens] =
origin match {
Expand Down