fix: return false in addChannel if package is not published on npm

semantic-release · Dec 14, 2018 · 5434bab · 5434bab
1 parent 4a41228
commit 5434bab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/add-channel.js b/lib/add-channel.js
@@ -42,4 +42,6 @@ module.exports = async ({npmPublish}, pkg, context) => {
       npmPublish === false ? 'npmPublish' : "package.json's private property"
     } is ${npmPublish !== false}`
   );
+
+  return false;
 };
diff --git a/test/integration.test.js b/test/integration.test.js
@@ -634,7 +634,7 @@ test('Skip adding the package to a channel ("npmPublish" is false)', async t =>
     }
   );
 
-  t.falsy(result);
+  t.false(result);
   await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env}));
 });
 
@@ -662,7 +662,7 @@ test('Skip adding the package to a channel ("package.private" is true)', async t
     }
   );
 
-  t.falsy(result);
+  t.false(result);
   await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env}));
 });