Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres support lock_timeout #15345

Closed
4 of 8 tasks
suonto opened this issue Nov 28, 2022 · 2 comments · Fixed by #15347
Closed
4 of 8 tasks

Postgres support lock_timeout #15345

suonto opened this issue Nov 28, 2022 · 2 comments · Fixed by #15347

Comments

@suonto
Copy link
Contributor

suonto commented Nov 28, 2022

Issue Creation Checklist

  • I understand that my issue will be automatically closed if I don't fill in the requested information
  • I have read the contribution guidelines

Feature Description

Support passing lock_timeout to pg client.

Lock timeout support was added to pg in 8.8.0:

Implementation

Pick also 'lock_timeout' here:

const connectionConfig: ClientConfig = {

Describe why you would like this feature to be added to Sequelize

Lock timeout is useful. Otherwise the underlying tech wouldn't support it.

Is this feature dialect-specific?

  • No. This feature is relevant to Sequelize as a whole.
  • Yes. This feature only applies to the following dialect(s): postgres

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I will need guidance.
  • No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in implementing my feature.

Indicate your interest in the addition of this feature by adding the 👍 reaction. Comments such as "+1" will be removed.

@WikiRik
Copy link
Member

WikiRik commented Nov 28, 2022

Seems like you already know how to implement this, is there any reason you do not have the time to open a PR? Since it's just an option to pass to the node-postgres package I do not really see more work that needs to be done

@suonto
Copy link
Contributor Author

suonto commented Nov 28, 2022

I can try to make time. You're right, shouldn't take long.

suonto pushed a commit to suonto/sequelize that referenced this issue Nov 28, 2022
suonto pushed a commit to suonto/sequelize that referenced this issue Nov 29, 2022
suonto pushed a commit to suonto/sequelize that referenced this issue Nov 29, 2022
suonto pushed a commit to suonto/sequelize that referenced this issue Nov 29, 2022
WikiRik pushed a commit that referenced this issue Nov 29, 2022
please see #15345.

Co-authored-by: Markus Suonto <markus.suonto@withsecure.com>
WikiRik added a commit that referenced this issue Nov 29, 2022
please see #15345.

Co-authored-by: Markus Suonto <markus.suonto@withsecure.com>
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants