Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: database version support info #12168

Merged
merged 1 commit into from Apr 25, 2020
Merged

Conversation

sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Adding support information related to database versions as starter.

@sushantdhiman sushantdhiman requested a review from a team April 25, 2020 16:17
@SimonSchick
Copy link
Contributor

@sushantdhiman can we just slap a retry on this test?

@sushantdhiman
Copy link
Contributor Author

@SimonSchick I'll take a look at this tomorrow probably, if can't find anything useful we can use retry

@sushantdhiman sushantdhiman merged commit e4510ea into master Apr 25, 2020
@sushantdhiman sushantdhiman deleted the minimum-supported-engine branch April 25, 2020 17:54
@sushantdhiman
Copy link
Contributor Author

@SimonSchick row locking test shouldn't bother us now #12174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants