Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Modern log improvements #10062

Merged
merged 3 commits into from Oct 7, 2021
Merged

CLI: Modern log improvements #10062

merged 3 commits into from Oct 7, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 7, 2021

  • Improve communication of resource progress (instead of a counter. present currently updated resources below main progress line)
  • Ensure empty space on final statuses, in commands which display progress bar
  • Expose function artifact sizes in final deploy summary

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, great improvements 👏

outputSectionItems.push(`${f.name}: ${f.deployedName}`);
outputSectionItems.push(
`${f.name}: ${f.deployedName}${
f.artifactSize ? style.aside(` (${filesize(f.artifactSize)})`) : ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@medikoo medikoo merged commit 8746100 into master Oct 7, 2021
@medikoo medikoo deleted the 1007-improve-logs branch October 7, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants