CLI: Fix open browser handling in interactive CLI #10461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When watching Steve's first steps demo (internal) we can notice that opening a browser window to set up a new provider doesn't work.
It appears bug on our side is that we pass ANSI colors decorated URL to
open
command, and that's not a valid URL. Unfortunately, this library doesn't report on that, but just silently runs it (with no effect). This patch fixes that.Additionally upgraded the
open
browser logic, and at the same time unified it with the one we use in the dashboard plugin for logging in. There's no longer a need to keep hardcoded internallyopen
implementation as we dropped support for Node.js v6 with v2 major./cc @mnapoli