Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: Throw if missing RoleName in Custom function role #8219

Merged
merged 3 commits into from Oct 7, 2020
Merged

DX: Throw if missing RoleName in Custom function role #8219

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba76541
Throw if missing role name
DavidWells Sep 10, 2020
db08289
maybe fix lint? I'm in Github UI
DavidWells Sep 10, 2020
8bfc5ba
use this.serverless.classes.Error
DavidWells Sep 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/plugins/aws/deployFunction/index.js
View file
Open in desktop
Expand Up @@ -77,8 +77,10 @@ class AwsDeployFunction {
if (roleResource.Type !== 'AWS::IAM::Role') {
throw new Error('Provided resource is not IAM Role.');
}

const roleProperties = roleResource.Properties;
if (!roleProperties.RoleName) {
throw new this.serverless.classes.Error('Role resource missing RoleName property');
}
const compiledFullRoleName = `${roleProperties.Path || '/'}${roleProperties.RoleName}`;

return this.provider
Expand Down