New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AJV): Add Rest api logs definition #8309
feat(AJV): Add Rest api logs definition #8309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears tests relied on apiGatewayValidLogLevels
(see CI fail). If its' indeed needed over there, I would just hardcode it to test file
a5aba1d
to
cb6e0ce
Compare
Hardcoded it for the tests that needs it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fredericbarthelet it looks great. I have just one minor improvement suggestion. Let me know
Codecov Report
@@ Coverage Diff @@
## master #8309 +/- ##
==========================================
- Coverage 88.09% 88.08% -0.01%
==========================================
Files 250 250
Lines 9371 9368 -3
==========================================
- Hits 8255 8252 -3
Misses 1116 1116
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fredericbarthelet !
Addresses: #8018