test: Add error listener & ec3 test in codec switching integration test #6486
Conversation
avelad
added
the
component: tests
|
Incremental code coverage: 100.00% |
tykus160
changed the title
There was a problem hiding this comment.
@avelad, I see you making changes, so I'll let you give the final approval and merge when you're ready.
|
@joeyparrish This PR has bugs in Chromecast Ultra (we previously masked the error, in Edge (github actions) and Safari |
|
I know I've been asked to remove a video test due to the size of the segment from the Dolby asset, but it would be good to bring it back or reencode it to lower bitrate. |
Agree, you can do that! |
|
I'm off but I can do it next week, in this PR or in a new one, doesn't matter. |
We wait until next week, there is no rush. Additionally, the error still needs to be solved in Safari and Chromecast Ultra.... |
|
Intention of this PR was to reveal some potential issues around codec switching. I think fixes can be done separately as right now I don't even have an idea what's wrong. |
We could make fixes separately, but I don't want to merge a PR that leaves tests failing without a fix in sight. Now that #6523 is merged, all tests should be green on From the previous run, I can see a decoder error on Chromecast Ultra for aac -> opus, so smooth codec-switching may not work correctly on such devices. We may need to detect the model and ban it. I also see a failure on Safari that doesn't make a lot of sense to me on the surface, but I can help debug it. |
…st (#6486) Adding EC-3 test case for codec switching integration suite, as some platforms, i.e. Tizen 3 do not support Opus --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
…st (#6486) Adding EC-3 test case for codec switching integration suite, as some platforms, i.e. Tizen 3 do not support Opus --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
…st (#6486) Adding EC-3 test case for codec switching integration suite, as some platforms, i.e. Tizen 3 do not support Opus --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Adding EC-3 test case for codec switching integration suite, as some platforms, i.e. Tizen 3 do not support Opus