Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add error listener & ec3 test in codec switching integration test #6486

Merged
merged 15 commits into from May 6, 2024
Merged

test: Add error listener & ec3 test in codec switching integration test #6486

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c125125
add error listener
tykus160 Apr 26, 2024
03d96a7
Merge remote-tracking branch 'hugo/master' into wt-test-codec
tykus160 Apr 26, 2024
66ab8dc
add ec3 test
tykus160 Apr 26, 2024
331e2a9
remove video
tykus160 Apr 26, 2024
59c853a
ec3 -> ec-3
tykus160 Apr 26, 2024
2a914f3
fix bugs in tests
tykus160 Apr 26, 2024
55b4f3b
Update codec_switching_integration.js
avelad Apr 29, 2024
335745d
Fix lint error
avelad Apr 29, 2024
d404050
Fix ec-3 test in Edge (github actions)
avelad Apr 30, 2024
c8b548b
Merge remote-tracking branch 'hugo/master' into wt-test-codec
tykus160 May 6, 2024
a65a1d1
move unload to afterEach
tykus160 May 6, 2024
60cff79
remove codec switch SMOOTH for non-android chromecast
tykus160 May 6, 2024
2efe437
add new platform method
tykus160 May 6, 2024
e1aa2ab
increase timers
tykus160 May 6, 2024
7703891
remove fdescribe
tykus160 May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/util/platform.js
View file
Open in desktop
Expand Up @@ -562,6 +562,10 @@ shaka.util.Platform = class {
Platform.isWebOS4() || Platform.isWebOS5()) {
return false;
}
// Older chromecasts without GoogleTV seem to not support SMOOTH properly.
if (Platform.isChromecast() && !Platform.isAndroid()) {
tykus160 marked this conversation as resolved.
Show resolved Hide resolved
return false;
}
// See: https://chromium-review.googlesource.com/c/chromium/src/+/4577759
if (Platform.isWindows() && Platform.isEdge()) {
return false;
Expand Down
17 changes: 1 addition & 16 deletions test/codec_switching/codec_switching_integration.js
View file
Open in desktop
Expand Up @@ -63,6 +63,7 @@ describe('Codec Switching', () => {
});

afterEach(async () => {
await player.unload();
eventManager.release();
await player.destroy();
});
Expand Down Expand Up @@ -102,8 +103,6 @@ describe('Codec Switching', () => {
variants = player.getVariantTracks();

expect(variants.find((v) => !!v.active).language).toBe('es');

await player.unload();
});

it('can switch codecs SMOOTH', async () => {
Expand Down Expand Up @@ -140,8 +139,6 @@ describe('Codec Switching', () => {
variants = player.getVariantTracks();

expect(variants.find((v) => !!v.active).language).toBe('es');

await player.unload();
});
});

Expand Down Expand Up @@ -175,8 +172,6 @@ describe('Codec Switching', () => {
variants = player.getVariantTracks();

expect(variants.find((v) => !!v.active).language).toBe('es');

await player.unload();
});

it('can switch codecs SMOOTH', async () => {
Expand Down Expand Up @@ -212,8 +207,6 @@ describe('Codec Switching', () => {
variants = player.getVariantTracks();

expect(variants.find((v) => !!v.active).language).toBe('es');

await player.unload();
});
});

Expand Down Expand Up @@ -248,8 +241,6 @@ describe('Codec Switching', () => {
variants = player.getVariantTracks();

expect(variants.find((v) => !!v.active).language).toBe('es');

await player.unload();
});

it('can switch codecs SMOOTH', async () => {
Expand Down Expand Up @@ -286,8 +277,6 @@ describe('Codec Switching', () => {
variants = player.getVariantTracks();

expect(variants.find((v) => !!v.active).language).toBe('es');

await player.unload();
});
});

Expand Down Expand Up @@ -322,8 +311,6 @@ describe('Codec Switching', () => {
variants = player.getVariantTracks();

expect(variants.find((v) => !!v.active).language).toBe('en');

await player.unload();
});

it('can switch codecs SMOOTH', async () => {
Expand Down Expand Up @@ -360,8 +347,6 @@ describe('Codec Switching', () => {
variants = player.getVariantTracks();

expect(variants.find((v) => !!v.active).language).toBe('en');

await player.unload();
});
});
});