Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple-icons to v1.17.1 #24

Merged
merged 2 commits into from Oct 10, 2019
Merged

Update simple-icons to v1.17.1 #24

merged 2 commits into from Oct 10, 2019

Conversation

ericcornelissen
Copy link
Contributor

@ericcornelissen ericcornelissen added the dependencies Pull requests that update a dependency file label Oct 7, 2019
@ericcornelissen
Copy link
Contributor Author

There seems to be a problem with some of the newly added icons, it seems SVGO(MG) is a bit to aggressive with its minification process. It not only affects this process, but it also prevents Adobe Illustrator from displaying the SVGs.

A fix for this problem should be available soon through simple-icons/simple-icons#1718

@ericcornelissen ericcornelissen marked this pull request as ready for review October 9, 2019 20:14
@ericcornelissen ericcornelissen changed the title Update simple-icons to v1.17.0 Update simple-icons to v1.17.1 Oct 9, 2019
@ericcornelissen ericcornelissen merged commit eed566b into simple-icons:develop Oct 10, 2019
@ericcornelissen ericcornelissen deleted the deps/update-simple-icons branch October 10, 2019 06:14
ericcornelissen added a commit that referenced this pull request Oct 11, 2019
* Update status badge in README.md

* Update Simple Icons to v1.14.0 (#20)

* Update SimpleIcons dependency to v1.12.0

* Fix build error due to new `.get` API function [REVERTED]

This solution is a bit of a hack. I think the real solution needs to be 
found up-stream.

* Update SimpleIcons dependency to v1.13.0

* Update SimpleIcons dependency to v1.14.0

* Run local server with test script (#23)

Run local server with test script using anywhere. This automatically builds the test-page and opens it for you in a local server.

Having it open in a local server prevents issues as described in #19

* Update simple-icons to v1.17.1 (#24)

* Use 'slug' property in build script (#25)

* Replace usage of titleToFilename by icon.slug

* Remove utilities module as it is no longer used

* [CI] Custom script for release stage

* version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant