[Patch] Fix potential display issues with 11 icons #1718
Conversation
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
To fix display issues in some cases (e.g. Adobe Illustrator)
Which should ensure the problems fixed in the previous commits don't occur in the future.
There was a problem hiding this comment.
Nice catch. Did you discover this from a bug report or just stumbling upon it?
This looks good to me regardless. As for what to merge into, there are basically two options:
- Cherry-pick the commits from this PR onto a new branch based off of
develop, merge that intodevelopthen merge that intomaster. This follows our normal flow. - Merge this PR, then merge
masterintodevelop
For the sake of saving a bit of work, I'm fine with 2. The only downside is an extra merge commit on the develop branch.
I noticed the problem already when reviewing one of the PRs for the latest release but at that time I thought it was something I did wrong (besides, the particular SVG that I tested was replaced with another version before it was merged into
These commits actually branch off of |
This patch fixes potential display issues with 11 icons added over the last 3 versions. These icons could not be displayed by Adobe Illustrator (and potentially other software).
I also included an update to the SVGO configuration file that I used to fix these problems. It seems one aspect of the optimization process (which was introduced in v1.3.0) is a bit too much for some (older?) software.
Note: this Pull Request merges directly into
master. I'm not sure if this is how we want to release patches. My idea was to merge this directly intomasterand then mergemasterintodevelop. Alternatively we can merge this branch intodevelopseparately, but in that case I'm not sure how the next merge fromdevelopintomasterwill look like...